Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: update amount block settings with descriptions #7353

Merged
merged 7 commits into from
Apr 15, 2024
Merged

Feature: update amount block settings with descriptions #7353

merged 7 commits into from
Apr 15, 2024
+38 −20

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Apr 15, 2024 •
edited
Loading

Resolves: https://stellarwp.atlassian.net/jira/software/c/projects/GIVE/boards/382?selectedIssue=GIVE-620

Description

  • Add descriptions to amount block attributes
  • Add type for descriptions
  • Pass new data to the OptionsPanel component.

Requires related PR:

impress-org/form-builder-library#7

Affects

Donation Amount Block Settings

Visuals

Testing Instructions

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh changed the base branch from develop to epic/donation-amount-level-descriptions April 15, 2024 20:57
@JoshuaHungDinh JoshuaHungDinh changed the title Feature: update donation level settings with descriptions Feature: update amount block settings with descriptions Apr 15, 2024
@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review April 15, 2024 20:58
@JoshuaHungDinh JoshuaHungDinh merged commit 1750a6c into epic/donation-amount-level-descriptions Apr 15, 2024
20 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the feature/add-level-description-settings branch April 15, 2024 23:22
@JoshuaHungDinh JoshuaHungDinh mentioned this pull request Apr 24, 2024
Merged
5 tasks
pauloiankoski pushed a commit that referenced this pull request Apr 24, 2024
@JoshuaHungDinh @pauloiankoski
Feature: update amount block settings with descriptions (#7353)
11f4882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauloiankoski pauloiankoski pauloiankoski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaHungDinh @pauloiankoski